Open
Conversation
Author
|
@rigoucr @edwtorba @generalredneck I could use some help here.
|
added 8 commits
May 17, 2024 10:42
generalredneck
approved these changes
Sep 6, 2024
Contributor
generalredneck
left a comment
There was a problem hiding this comment.
I mean this looks pretty solid from a code perspective. I say we start giving it a shot and see where it fails.
Author
|
@rigoucr Allan approved the code; I also went ahead and removed the ZD ticket creation. |
Contributor
|
Hi all, If I follow, it looks like this can be merged in and released??? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
There is a tad bit more cleanup to do as well. I also noticed some different approaches to how I can handle things like extracting the task id from the response usingThis did not work for me so I reverted to what I had working.jq. I didn't know ifjqwould be available until I saw it in the code elsewhere.